-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move old yammer recipe to /viva-engage
#584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vraravam
requested changes
Oct 4, 2024
This reverts commit 42c51d0.
vraravam
requested changes
Oct 4, 2024
This reverts commit 42c51d0.
vraravam
approved these changes
Oct 4, 2024
@all-contributors please add @marrws for code |
I've put up a pull request to add @marrws! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
February last year Microsoft renamed Yammer to Viva Engage 1 and the old
yammer.com
now redirects tohttps://engage.cloud.microsoft
. This change moves the old/yammer
recipe to/viva-engage
and refactor the selector for notifications and messages.Maybe the
hasIndirectMessages
should be set tofalse
because for my organization this notification pops-up for every internal announcement, not only for private/direct messages. I leave that decision to you guys.Footnotes
https://www.microsoft.com/en-us/microsoft-365/blog/2023/02/13/yammer-is-evolving-to-microsoft-viva-engage-with-new-experiences-rolling-out-today/ ↩